fix: assets copying from 'nest build' is problematic #1264
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Currently the closeWatcher executes midway of copying assets. Very notisable in a file structure with a lot of subfolders/files.
Issue Number: #1117
What is the new behavior?
Refactored closeWatchers to check if a recent action has been exectued in order to reduce race conditions and reset the timer. Additional timeout will trigger repeating the process until a recent action has not been executed, at which it will close the watchers.
Note: The race condition could still be a problematic factor when copying bigger files, I'd assume, for which a more clever/robust solution should be applied. Additionally the timeout of 300 was increased to 500 to lessen the timeout spam on the event loop. Could be increased further upon analysing or set dynamically based on file sizes/files count ratio to reduce spam.
Does this PR introduce a breaking change?
Other information
This was a pickle to investigate. Good find.