Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: replace aliased imports for tsx and jsx files #1554

Merged
merged 2 commits into from
Mar 3, 2022
Merged

fix: replace aliased imports for tsx and jsx files #1554

merged 2 commits into from
Mar 3, 2022

Conversation

pkerschbaum
Copy link
Contributor

@pkerschbaum pkerschbaum commented Mar 2, 2022

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Other... Please describe:

What is the current behavior?

Commands like nest start and nest build replace the path of imports using path aliases with its relative path.
But this currently fails for imports pointing to a .tsx or jsx file.

Issue Number: #1547

What is the new behavior?

Path aliases are replaced not only for imports pointing to .ts and .js files, but for .tsx or jsx also.

Does this PR introduce a breaking change?

[ ] Yes
[x] No

@pkerschbaum pkerschbaum changed the title fix: replace aliased imports of tsx files fix: replace aliased imports for tsx and jsx files Mar 2, 2022
@kamilmysliwiec
Copy link
Member

LGTM 🎉

@kamilmysliwiec kamilmysliwiec merged commit bf6e41c into nestjs:master Mar 3, 2022
@pkerschbaum pkerschbaum deleted the fix/replace-aliased-imports-of-tsx-files branch March 3, 2022 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants