Merge pull request #14097 from clkamp/wip-distance-order

fix(core): revisit dependencies w/ possibly higher distance
nestjs · Nov 8, 2024 · 84bf570 · 84bf570
2 parents 3081f54 + 2c8982a
commit 84bf570
Showing 1 changed file with 5 additions and 5 deletions.
diff --git a/packages/core/scanner.ts b/packages/core/scanner.ts
@@ -389,20 +389,20 @@ export class DependenciesScanner {
     // Skip "InternalCoreModule" from calculating distance
     modulesGenerator.next();
 
-    const modulesStack = [];
-    const calculateDistance = (moduleRef: Module, distance = 1) => {
-      if (!moduleRef || modulesStack.includes(moduleRef)) {
+    const calculateDistance = (moduleRef: Module, distance = 1, modulesStack = []) => {
+      const localModulesStack = [...modulesStack];
+      if (!moduleRef || localModulesStack.includes(moduleRef)) {
         return;
       }
-      modulesStack.push(moduleRef);
+      localModulesStack.push(moduleRef);
 
       const moduleImports = moduleRef.imports;
       moduleImports.forEach(importedModuleRef => {
         if (importedModuleRef) {
           if (distance > importedModuleRef.distance) {
             importedModuleRef.distance = distance;
           }
-          calculateDistance(importedModuleRef, distance + 1);
+          calculateDistance(importedModuleRef, distance + 1, localModulesStack);
         }
       });
     };