fix: skip caching the response if it is a streamable file instance #11066
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
If the
CacheIntereceptor
is used and aStreamableFile
is returned, the class instance won't be properly cached due to serialization of the stream.Issue Number: #10575
What is the new behavior?
This is the easier fix to do rather than taking the stream and serializing it to something that can be cached in. If we'd rather actually serialize the stream I can work on that functionality instead
Does this PR introduce a breaking change?
Other information