Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: skip caching the response if it is a streamable file instance #11066

Merged

Conversation

jmcdo29
Copy link
Member

@jmcdo29 jmcdo29 commented Feb 7, 2023

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

What is the current behavior?

If the CacheIntereceptor is used and a StreamableFile is returned, the class instance won't be properly cached due to serialization of the stream.

Issue Number: #10575

What is the new behavior?

This is the easier fix to do rather than taking the stream and serializing it to something that can be cached in. If we'd rather actually serialize the stream I can work on that functionality instead

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@coveralls
Copy link

Pull Request Test Coverage Report for Build 14da9cb9-8c0b-45d6-a33d-0e8a13d1602a

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 92.926%

Totals Coverage Status
Change from base Build 50eb7c20-fcbc-45f9-a835-3c087cce57ff: 0.0%
Covered Lines: 6463
Relevant Lines: 6955

💛 - Coveralls

@kamilmysliwiec
Copy link
Member

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants