fix(common): account for when stack is undefined in logger #11081
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Due to a change in nestjs#10531 when the `stack` is added as `undefined` a new `undefined` log would be added whenever `this.logger.error()` would be called. Now, we check that the last element is either a string or undefined, and if so strip the last element. That element should only exist when we artificially add the stack via the changes from nestjs#10531. closes nestjs#11074
15 tasks
Pull Request Test Coverage Report for Build da944cb9-1f9c-4bfc-9622-15b0ed459a6a
💛 - Coveralls |
micalevisk
reviewed
Feb 8, 2023
jmcdo29
force-pushed
the
fix/logger-error-parameters
branch
from
87335fa
to
bd74c7f
Compare
micalevisk
approved these changes
Feb 8, 2023
|
lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Due to a change in #10531 when the
stackis added asundefineda newundefinedlog would be added wheneverthis.logger.error()would be called.Issue Number: #11074
What is the new behavior?
Now, we check that the last element is either a string or undefined, and if so strip the last element. That element should only exist when we artificially add the stack via the changes from #10531.
Does this PR introduce a breaking change?
This at least shouldn't be breaking. Added a new test to ensure it does what I expect it to as well.
Other information