-
-
Notifications
You must be signed in to change notification settings - Fork 7.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: allow extension of microservice event and message extras #11426
Merged
kamilmysliwiec
merged 2 commits into
nestjs:master
from
voiceflow:feat/extend-microservice-extras
Apr 5, 2023
Merged
feat: allow extension of microservice event and message extras #11426
kamilmysliwiec
merged 2 commits into
nestjs:master
from
voiceflow:feat/extend-microservice-extras
Apr 5, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build e9fc9f40-fb07-41c8-884f-da34d1cc6418
💛 - Coveralls |
LGTM |
This was referenced May 24, 2024
This was referenced Jul 20, 2024
This was referenced Sep 7, 2024
This was referenced Sep 24, 2024
This was referenced Sep 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Ran into this challenge when creating a custom transport strategy. As far as I can tell there's no way to read additional metadata off of our handlers within the strategy itself; we just have access to the
extras
object.However, the extras object can only be set when using the
@MessagePattern
or@EventPattern
decorator reliably because they will always override any existing extras.Issue Number: N/A
What is the new behavior?
With this change the
@MessagePattern
and@EventPattern
decorators will merge their extras with any existing extras found.In our custom transport framework we have multiple decorators which work the same way as the
@HttpCode
decorator does for an HTTP transport by adding additional metadata that is respected when handling the request. However for the transport technology we're using we need the metadata at binding time vs when the handler is executed, and the extras object is the only metadata available at binding timeDoes this PR introduce a breaking change?
Other information