feat(microservices): allow grpc-server graceful shutdown #12014
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
The
grpc-server
always closes usingforceShutdown()
. That does not allow graceful shutdown of the application.Issue Number: #12005
What is the new behavior?
Added a
gracefulShutdown
option for gRPC. When set totrue
,grpc-server
will usetryShutdown
when closing instead offorceShutdown
.Does this PR introduce a breaking change?
Other information
GrpcOptions
is shared betweenserver-grpc
andclient-grpc
. So technically, it is possible to setgracefulShutdown
even for the client. Unfortunately, graceful shutdown does not seem currently available for the client in grpc-js (see grpc/grpc-node#1340)