fix(microservices): support client cancel grpc request in unary stream #12026
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 2e139aca-bd85-405b-b32b-ed5ca31697ba
💛 - Coveralls |
1 task
| return; | ||
| } | ||
| } | ||
| return observer.error(this.serializeError(error)); |
There was a problem hiding this comment.
nit: formatting is broken?
There was a problem hiding this comment.
Thank you. Just commit the fix.
| afterEach(() => { | ||
| // invoke client callback to allow resources to be cleaned up | ||
| clientCallback(null, {}); | ||
| }); |
There was a problem hiding this comment.
Why this hook was removed?
There was a problem hiding this comment.
Thank you. Just commit the fix.
…m - fix pull-request
|
@kamilmysliwiec please help check the fix |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Unsubscribe unary request with client upstream do nothing:
Issue Number: #12023
What is the new behavior?
When unsubscribe unary request with client upstream:
call.cancel()to cancel request & release resourceDoes this PR introduce a breaking change?
Other information