Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: #13077 KafkaJs typing consistency #13084

Merged
merged 1 commit into from
Feb 7, 2024

Conversation

edeesis
Copy link
Contributor

@edeesis edeesis commented Jan 23, 2024

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

What is the current behavior?

Incompatible typing between the KafkaJs and Nest Kafka Microservice types.

Issue Number: #13077

What is the new behavior?

This will change the SASL Mechanism to be compatible types.

Does this PR introduce a breaking change?

  • Yes
  • No

While technically this is a breaking change, since we Object.assign, the current signature actually won't work: https://github.com/edeesis/nest/blob/master/packages/microservices/server/server-kafka.ts#L114-L118.

The signature change was introduced in kafkajs 2.2.1.

Other information

@coveralls
Copy link

Pull Request Test Coverage Report for Build 1fe0a501-248d-4b5d-99c3-71f2989b8bfa

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.1%) to 92.1%

Totals Coverage Status
Change from base Build 11e860cb-424d-4422-878c-e23b0381b86b: -0.1%
Covered Lines: 6715
Relevant Lines: 7291

💛 - Coveralls

@kamilmysliwiec kamilmysliwiec mentioned this pull request Jan 24, 2024
15 tasks
@kamilmysliwiec kamilmysliwiec merged commit c7e1e24 into nestjs:master Feb 7, 2024
3 checks passed
@kamilmysliwiec
Copy link
Member

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants