Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core,common,platform-fastify): add webdav http methods support #13278

Merged
merged 8 commits into from
Nov 18, 2024

Conversation

johaven
Copy link
Contributor

@johaven johaven commented Feb 29, 2024

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

What is the current behavior?

Closes #9459
Old PR: #13164

What is the new behavior?

add new decorators for webdav methods, like @propfind

Does this PR introduce a breaking change?

  • Yes
  • No

Status

Everything works on both platforms (express, fastify)

@coveralls
Copy link

coveralls commented Feb 29, 2024

Pull Request Test Coverage Report for Build 2312ec74-c093-40b0-b43c-0268b5148ba5

Details

  • 21 of 21 (100.0%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.02%) to 92.265%

Totals Coverage Status
Change from base Build 3047ae8a-a5a4-402c-9e7d-49c14e1ba997: 0.02%
Covered Lines: 6775
Relevant Lines: 7343

💛 - Coveralls

@johaven
Copy link
Contributor Author

johaven commented Jun 3, 2024

Looks good to me

@johaven johaven force-pushed the feat-webdav-methods branch from 5489c3d to e064680 Compare July 2, 2024 14:50
@johaven johaven force-pushed the feat-webdav-methods branch from 04d3eba to 79b3afe Compare July 9, 2024 22:36
@johaven johaven force-pushed the feat-webdav-methods branch 2 times, most recently from 9608fe8 to 876131d Compare August 12, 2024 09:16
@johaven johaven force-pushed the feat-webdav-methods branch from 876131d to b62b925 Compare August 12, 2024 09:19
@kamilmysliwiec kamilmysliwiec added this to the 11.0.0 milestone Nov 18, 2024
@kamilmysliwiec kamilmysliwiec changed the base branch from master to 11.0.0 November 18, 2024 12:16
@kamilmysliwiec kamilmysliwiec merged commit 3973900 into nestjs:11.0.0 Nov 18, 2024
5 checks passed
@kamilmysliwiec kamilmysliwiec mentioned this pull request Nov 20, 2024
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

WebDAV request method support
5 participants