Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(fastify): update fastify static options interface #14116

Conversation

Tony133
Copy link
Contributor

@Tony133 Tony133 commented Nov 7, 2024

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Proposal:

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@Tony133 Tony133 changed the title refactor(): update fastify static options interface refactor(fastify): update fastify static options interface Nov 7, 2024
@coveralls
Copy link

Pull Request Test Coverage Report for Build dc6e204c-b705-4972-a5da-ae32f0647ea0

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 6 unchanged lines in 3 files lost coverage.
  • Overall coverage decreased (-0.03%) to 92.213%

Files with Coverage Reduction New Missed Lines %
packages/common/pipes/validation.pipe.ts 1 94.34%
packages/core/inspector/initialize-on-preview.allowlist.ts 1 75.0%
packages/core/injector/internal-core-module/internal-core-module-factory.ts 4 80.0%
Totals Coverage Status
Change from base Build 72f148bc-4145-44b3-a3c4-06a616307114: -0.03%
Covered Lines: 6750
Relevant Lines: 7320

💛 - Coveralls

@kamilmysliwiec
Copy link
Member

Was it added in the latest version (that is not yet compatible with Nest)?

@Tony133
Copy link
Contributor Author

Tony133 commented Nov 8, 2024

Was it added in the latest version (that is not yet compatible with Nest)?

With the new version of Fastify 5.x, a small change has been made to the interface, see here : fastify/fastify-static@426f3be#diff-093ad82a25aee498b11febf1cdcb6546e4d223ffcb49ed69cc275ac27ce0ccceL80
The version of the @fastify/static package released for Fastify 5.x and v8.0.0, is now v8.0.2

@kamilmysliwiec
Copy link
Member

So if that's the case, shouldn't we target the 11.0.0 branch instead of master?

@Tony133
Copy link
Contributor Author

Tony133 commented Nov 8, 2024

So if that's the case, shouldn't we target the 11.0.0 branch instead of master?

I think we can also merge it into v10.x only that that small change was made in the new version of the @fastify/static v8.0.0 package which is only compatible with fastify v5.x, at best I can remove it and make a separate PR with that small change.

@kamilmysliwiec kamilmysliwiec changed the base branch from master to 11.0.0 November 8, 2024 11:26
@kamilmysliwiec kamilmysliwiec added this to the 11.0.0 milestone Nov 8, 2024
@kamilmysliwiec kamilmysliwiec merged commit fb32ef6 into nestjs:11.0.0 Nov 8, 2024
5 checks passed
@kamilmysliwiec kamilmysliwiec mentioned this pull request Nov 20, 2024
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants