-
-
Notifications
You must be signed in to change notification settings - Fork 7.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(microservices): add status, unwrap, on, and other features #14142
Merged
kamilmysliwiec
merged 11 commits into
11.0.0
from
feat/microservice-client-server-additions
Nov 20, 2024
+2,130
−866
Merged
Changes from 9 commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
3dfc7fc
feat(microservices): add status, unwrap, on, and other features
kamilmysliwiec f983f03
fix: update broken import paths
kamilmysliwiec f2b6cc0
fix: fix minor type issues, broken imports
kamilmysliwiec 66c3ab2
sample: update grpc client options type
kamilmysliwiec 259b5dd
fix: remove duplicated client redis message handler
kamilmysliwiec 3267135
chore: resolve merge conflicts
kamilmysliwiec bc31b5c
test: update tcp config opts type
kamilmysliwiec 4f55f88
Update packages/microservices/server/server-nats.ts
kamilmysliwiec 129fe79
Update packages/microservices/server/server-rmq.ts
kamilmysliwiec 9356509
Update packages/microservices/server/server-nats.ts
kamilmysliwiec c66d1fb
fix: add type constraints and assertions
kamilmysliwiec File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if we could add an
tsconfig.json#compilerOptions.paths
entry that replaces these optional dependencies withany
on-compile 🤔 You'd get type-safety in the IDE, or when runningtsc --noEmit
This would require a separate tsconfigs for development and compilation, and fiddling with the build system is probably not worth the small gain in DX.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tsc
does not auto-replace paths fromtsconfig.json#compilerOptions.paths
(it leaves them as is)