feat(microservices): return all clients from kafka unwrap #14469
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: #11616
While the new major release ships an ability to unwrap underlying server instance, it's still not possible to manipulate on existing consumer and producer instances which are created in
start
method. As an example provided in the issue, we still can't subscribe heartbeat event on consumer created by NestJSWhat is the new behavior?
Following the example in Redis server, we can return all created instances, but not just client instance. In this case everyone can get an access to consumer and producers
Does this PR introduce a breaking change?
unwrap
method is not type-safe and fully depend on developer who define expected type. If someone is already start usingunwrap
method we might get into the trouble of unexpected result and developer must change their expected type manuallyOther information