Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): Sort devDependencies package names #1031

Merged
merged 1 commit into from Sep 19, 2022
Merged

chore(deps): Sort devDependencies package names #1031

merged 1 commit into from Sep 19, 2022

Conversation

ghost
Copy link

@ghost ghost commented Sep 16, 2022

This is the order they would be in if you ran npm i <package> rather
than inserting manually

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

What is the current behavior?

devDependencies are unsorted
Issue Number: N/A

What is the new behavior?

They are now sorted

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

This is as if you had installed them with `npm i <package>` where they
would be automatically sorted
@ghost
Copy link
Author

ghost commented Sep 16, 2022

I was playing around with the fastify version of this plugin and noticed that the names weren't sorted, so I figured I would get that straightened out.

@kamilmysliwiec kamilmysliwiec merged commit 0b50799 into nestjs:master Sep 19, 2022
@kamilmysliwiec
Copy link
Member

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants