Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(fix): Remove unnecessary @prettier/typescript-eslint #1032

Merged
merged 1 commit into from Nov 21, 2022
Merged

chore(fix): Remove unnecessary @prettier/typescript-eslint #1032

merged 1 commit into from Nov 21, 2022

Conversation

ghost
Copy link

@ghost ghost commented Sep 16, 2022

As per this error message:

Cannot read config file: /path/to/projects/nestjs-passport/node_modules/eslint-config-prettier/@typescript-eslint.js Error: "prettier/@typescript-eslint" has been merged into "prettier" in eslint-config-prettier 8.0.0. See: https://github.com/prettier/eslint-config-prettier/blob/main/CHANGELOG.md#version-800-2021-02-21

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

What is the current behavior?

eslint-config-prettier warns about an unnecessary config file
Issue Number: N/A

What is the new behavior?

the warning is gone

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

As per this error message:
```
Cannot read config file: /path/to/projects/nestjs-passport/node_modules/eslint-config-prettier/@typescript-eslint.js Error: "prettier/@typescript-eslint" has been merged into "prettier" in eslint-config-prettier 8.0.0. See: https://github.com/prettier/eslint-config-prettier/blob/main/CHANGELOG.md#version-800-2021-02-21
```
@kamilmysliwiec kamilmysliwiec merged commit a1bbfec into nestjs:master Nov 21, 2022
@kamilmysliwiec
Copy link
Member

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants