Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add files field in package.json to only include dist files #1086

Merged
merged 1 commit into from
Feb 1, 2023

Conversation

ydcjeff
Copy link
Contributor

@ydcjeff ydcjeff commented Nov 10, 2022

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe: package distribution

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

By only including distribution files, this could reduce the package size.

@kamilmysliwiec
Copy link
Member

What's the reason for this change?

@ydcjeff
Copy link
Contributor Author

ydcjeff commented Nov 10, 2022

With this, users don't need to download unnecessary files to use the package. Currently, the distribution includes test directory, coverage, tsconfig files, etc which are not needed from the user view point.

I noticed other @nestjs/* packages that I used has fields defined, but this one doesn't.

@ydcjeff
Copy link
Contributor Author

ydcjeff commented Nov 24, 2022

Can we merge this PR? @kamilmysliwiec

@kamilmysliwiec kamilmysliwiec merged commit 9675033 into nestjs:master Feb 1, 2023
@kamilmysliwiec
Copy link
Member

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants