fix: add optional decorator for property based injection #824
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
After moving the
AuthModuleOptions
to a property so that theAuthGuard()
could be better extended, Nest started throwing errors about not being able to find theAuthModuleOptions
. This is because ti is no longer optional.Issue Number: #823
What is the new behavior?
Back to the behavior in 8.0.0 with the property being optional, but it's also still a property
Does this PR introduce a breaking change?
Other information
I've added in some tests to show it's working without having to use
register
, I want to add more for a nested set up and show it's fully working, but I don't want to delay this fix from rolling out.Closes #823