Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add type to context parameter on IAuthGuard #905

Merged
merged 1 commit into from
Jul 8, 2022
Merged

feat: add type to context parameter on IAuthGuard #905

merged 1 commit into from
Jul 8, 2022

Conversation

micalevisk
Copy link
Member

@micalevisk micalevisk commented May 21, 2022

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

What is the current behavior?

as of now, the context parameter of handleRequest and getAuthenticateOptions methods is any

I'm pretty sure the type will always be ExecutionContext from @nestjs/common due to how those methods are invoked below:

async canActivate(context: ExecutionContext): Promise<boolean> {
const options = {
...defaultOptions,
...this.options,
...(await this.getAuthenticateOptions(context))

this.handleRequest(err, user, info, context, status)

What is the new behavior?

adds the type ExecutionContext to them, instead of any

Does this PR introduce a breaking change?

  • Yes
  • No

@micalevisk micalevisk changed the title feat: typing context parameter on IAuthGuard feat: add type to context parameter on IAuthGuard May 21, 2022
@kamilmysliwiec kamilmysliwiec merged commit eb5378c into nestjs:master Jul 8, 2022
@micalevisk micalevisk deleted the patch-1 branch July 8, 2022 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants