Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support x-enumNames param for client code generations #3067

Merged
merged 1 commit into from
Sep 17, 2024

Conversation

nadavhalfon
Copy link
Contributor

@nadavhalfon nadavhalfon commented Sep 10, 2024

Supporting numeric enums for client code generators

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

What is the current behavior?

When using a client swagger generator for numeric enums there is a missing feature for setting the enum names, causing a problem when needed to use a numeric enum without success, adding 'x-enumNames' with ts-ignore causing the param to not be copy to the component created when using 'enumName'

Issue Number: N/A

What is the new behavior?

When copying the params of the enum to the created component add also 'x-enumNames', and then the numeric enum will be generated fine using a codegen

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@kamilmysliwiec
Copy link
Member

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants