Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ark, skanlite, spectacle #8

Merged
merged 3 commits into from
Oct 27, 2022
Merged

ark, skanlite, spectacle #8

merged 3 commits into from
Oct 27, 2022

Conversation

Dejweed
Copy link
Contributor

@Dejweed Dejweed commented Oct 25, 2022

Hello!

I added some symlinks for KDE programs. I only added 64 where it looked finished. Also fixed the edit-find icon.

I would love to contribute more, but I'm quite new to git and all that stuff. Do you have any suggestions regarding commits and pull requests? Is it better to commit minor changes here and there or should I wait and then pull request all at once?

Thank you and keep up the good work :)

@nestoris
Copy link
Owner

Thank you. I'm a newbie too :-) so I also did not fully understand how to check the comparison of changes in graphic (especially svg) files. I'll try to accept the commit, and let's see what happens then :-)

@nestoris nestoris merged commit 766b178 into nestoris:main Oct 27, 2022
@nestoris
Copy link
Owner

nestoris commented Oct 27, 2022

Use this gawk-script for quickly and easy making of symlinks in the theme.
https://github.com/nestoris/Scripts/blob/main/iconlink
install it in somewhere in your $PATH, go to directory (for example) SE98/actions and run iconlink foo foo-symbolic, it will look in sizes directories for the foo.png, and if it exists, will create a symlink foo-symbolic.png with a target foo.png.
You can run it without arguments and get complete help.
P.S. only works in trees like theme/context/size/icon.png

@nestoris
Copy link
Owner

any contribution is welcome! :-)

@Dejweed
Copy link
Contributor Author

Dejweed commented Oct 27, 2022

Awesome! Do you keep track of stuff like apps.txt and icons.html or anything else I should be aware of? Also what desktop environment do you use? I'm on kde and I think it would be cool if symbolic icons would change color when using a dark theme (so far default breeze does that), but it uses svg and I did some testing and I would have to replace all pngs with svgs to achieve the same result. I hope that wouldn't break anything with other DEs.

@nestoris
Copy link
Owner

nestoris commented Oct 27, 2022

Unfortunately, I can't translate the theme into svg. Because I constantly use pixel graphics, converting png images and ico files back and forth. I work with ico, and then with a program specially written by me, I install the icon formats in the theme folder according to the size. This is closely related to raster graphics. I think you can make a bash or gawk script using the gd library or system-call of Imagemagick to change the color of the icons to match the color of the theme. But I don't have time to do this.
In general, you can write a script that turns all pngs into svgs and put it in the SE98 folder so that every KDE user can convert it by one click if desired.
As for apps.txt and other text/hypertext files are remnants from Chicago95, a fork of which is my theme. I'll probably remove them or upgrade them if they're an eyesore.
I use Mate and Xfce as DE. I used TDE a bit to find names for KDE icons. I didn't dare to install KDE itself due to the low performance of my laptop.
P. S. Xfce, as I understand it, uses symbolic icons for the notification bar, so I made them symlinks. But maybe we can think in this direction.

@Dejweed
Copy link
Contributor Author

Dejweed commented Oct 27, 2022

Thats ok, I can convert them to svg with Inkscape. I just want to know if thats ok to do or should I just leave it as it is. I'll do some testing beforehand, of course.
P. S. Maybe we could also delete some svgs that look worse than png (looking at the categories/scalable directory). I'm not sure if they do anything useful.

@nestoris
Copy link
Owner

nestoris commented Oct 29, 2022

Really I want to remove all the svgs :-)
The philosophy of this theme is "raster only". If you can convert the largest formats of icons to svgs to replace the Chicago95 legacy 48x48 scaled ones it will be good temporary idea, but God willing, I would like to make all the icons in all formats in pixel png. At least in all formats used in GNU.
If you have the Telegram messenger, contact me: @dobromils -- it's more convenient for me to have discussions there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants