Clarify that file globbing occurs only at start #3347
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
firejail can blacklist (and now also whitelist) files based on glob pattern. This pattern is evaluated at firejail start, and not updated at run time. This patch documents this behavior.
rusty-snake
reviewed
Apr 11, 2020
|
Merged, Thanks. |
kmk3
added a commit
to kmk3/firejail
that referenced
this pull request
Sep 12, 2024
Remove extranous escape characters and fix bold escaping.
Command used to check for unusual escape sequences:
$ git grep -E '\\[^ "\f-]|\\f[^BR]' -- src/man/*.in
With this, the only escape sequences used are:
$ git grep -E -ho -e '\\-' -e '\\[^-][^ ]?' -- src/man/*.in |
LC_ALL=C sort | uniq -c
9 \"
1 \&.
1194 \-
23 \\
507 \fB
127 \fR
Related commits:
* 1379851 ("Baseline firejail 0.9.28", 2015-08-08)
* 1684c9e ("Fixes for man firejail (netblue30#2628)", 2019-03-29)
* 7352501 ("Clarify that file globbing occurs only at start",
2020-04-11) / PR netblue30#3347
* f54ee53 ("man text for --include command", 2021-03-05).
This is a follow-up to netblue30#6472.
Kind of relates to netblue30#5903.
kmk3
added a commit
to kmk3/firejail
that referenced
this pull request
Sep 13, 2024
Remove extranous escape characters and fix bold escaping.
Command used to check for unusual escape sequences:
$ git grep -E -e '\\f[^BR]' -e '\\[^ "\f-]' -- src/man/*.in
With this, the only escape sequences used are:
$ git grep -E -ho -e '\\-' -e '\\[^-][^ ]?' -- src/man/*.in |
LC_ALL=C sort | uniq -c
9 \"
1 \&.
1194 \-
23 \\
507 \fB
127 \fR
Related commits:
* 1379851 ("Baseline firejail 0.9.28", 2015-08-08)
* 1684c9e ("Fixes for man firejail (netblue30#2628)", 2019-03-29)
* 7352501 ("Clarify that file globbing occurs only at start",
2020-04-11) / PR netblue30#3347
* f54ee53 ("man text for --include command", 2021-03-05).
This is a follow-up to netblue30#6472.
Kind of relates to netblue30#5903.
kmk3
added a commit
that referenced
this pull request
Sep 13, 2024
Remove extranous escape characters and fix bold escaping.
Command used to check for unusual escape sequences:
$ git grep -E -e '\\f[^BR]' -e '\\[^ "\f-]' -- src/man/*.in
With this, the only escape sequences used are:
$ git grep -E -ho -e '\\-' -e '\\[^-][^ ]?' -- src/man/*.in |
LC_ALL=C sort | uniq -c
9 \"
1 \&.
1194 \-
23 \\
507 \fB
127 \fR
Related commits:
* 1379851 ("Baseline firejail 0.9.28", 2015-08-08)
* 1684c9e ("Fixes for man firejail (#2628)", 2019-03-29)
* 7352501 ("Clarify that file globbing occurs only at start",
2020-04-11) / PR #3347
* f54ee53 ("man text for --include command", 2021-03-05).
This is a follow-up to #6472.
Kind of relates to #5903.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
firejail can blacklist (and now also whitelist) files based on glob pattern. This pattern is evaluated at firejail start, and not updated at run time. This patch documents this behavior.
The problem
You should be able to reproduce this behavior by:
firejail --blacklist="${HOME}/somedir/*" /bin/bashThen, in another shell,
You can access this in the jailed shell. Stopping and restarting it gives the proper blacklisting.
Alternatives
Ideally, the blacklist glob would be evaluated at runtime, but that doesn't seem compatible with the approach firejail uses.