Keep vglusers group unless no3d is used (virtualgl) #4851
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
virtualgl[1] runs `chown root:vglusers` on `/dev/nvidia*` and on devices usually owned by the "render" group[2]. This makes them unavailable in the sandbox if `noroot` (which causes groups to be dropped) is used. Since firejail classifies all of the aforementioned devices as being `DEV_3D` on fs_dev.c (which means that they are controlled by `no3d`), treat the "vglusers" group the same as the "render" group (by always keeping "vglusers" unless `no3d` is used). See the discussion on netblue30#2042 (from this comment[3] onwards). [1] https://virtualgl.org [2] https://github.com/VirtualGL/virtualgl/blob/6f0b90be02d13171dfdfffb112485f4091a5904f/server/vglserver_config#L393 [3] netblue30#2042 (comment) Reported-by: @JCallicoat
|
merged, thanks! |
kmk3
added a commit
to kmk3/firejail
that referenced
this pull request
Feb 5, 2022
kmk3
added a commit
to kmk3/firejail
that referenced
this pull request
Sep 7, 2023
This group is apparently used on Gentoo[1]. Currently only the "audio" supplementary group is kept. Fixes netblue30#5992. See also commit f329386 ("Keep vglusers group unless no3d is used (virtualgl)", 2022-01-07) / PR netblue30#4851. [1] https://wiki.gentoo.org/wiki/PipeWire Reported-by: @amano-kenji
kmk3
added a commit
to kmk3/firejail
that referenced
this pull request
Sep 20, 2023
This group is apparently used on Gentoo[1]. Currently only the "audio" supplementary group is kept. Fixes netblue30#5992. See also commit f329386 ("Keep vglusers group unless no3d is used (virtualgl)", 2022-01-07) / PR netblue30#4851. [1] https://wiki.gentoo.org/wiki/PipeWire Reported-by: @amano-kenji
kmk3
added a commit
to kmk3/firejail
that referenced
this pull request
Sep 20, 2023
This group is apparently used on Gentoo[1]. Currently only the "audio" supplementary group is kept. Fixes netblue30#5992. See also commit f329386 ("Keep vglusers group unless no3d is used (virtualgl)", 2022-01-07) / PR netblue30#4851. [1] https://wiki.gentoo.org/wiki/PipeWire Reported-by: @amano-kenji
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
virtualgl[1] runs
chown root:vgluserson/dev/nvidia*and on devicesusually owned by the "render" group[2]. This makes them unavailable in
the sandbox if
noroot(which causes groups to be dropped) is used.Since firejail classifies all of the aforementioned devices as being
DEV_3Don fs_dev.c (which means that they are controlled byno3d),treat the "vglusers" group the same as the "render" group (by always
keeping "vglusers" unless
no3dis used).See the discussion on #2042 (from this comment[3] onwards).
[1] https://virtualgl.org
[2] https://github.com/VirtualGL/virtualgl/blob/6f0b90be02d13171dfdfffb112485f4091a5904f/server/vglserver_config#L393
[3] #2042 (comment)
Reported-by: @JCallicoat