-
Notifications
You must be signed in to change notification settings - Fork 569
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
profiles: safeguard single line comments #5950
Conversation
TBH uncommenting lines can break easily if you update firejail. |
And 👍 for |
Ah you beat me to it :p I also started working on this with a script (I probably should have commented It currently changes about ~220 files. Do you mind if we try the automated way first and then continue with this PR |
@rusty-snake Thanks. There's bound to be plenty of places left were we could streamline this. Perhaps we can add an item in the template so it's a bit more explicit for anyone who contributes and cares to actually follow the template.
@kmk3 Absolutely not, feel free to proceed with your scripted version 👍 . |
Let's close this now that #5987 takes over. |
Using
-
on single line comments can break easily when users just uncomment a line. It's advised to use#
instead.Relates to #5942