Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

profiles: safeguard single line comments #5950

Closed
wants to merge 86 commits into from

Conversation

glitsj16
Copy link
Collaborator

Using - on single line comments can break easily when users just uncomment a line. It's advised to use # instead.

Relates to #5942

@rusty-snake
Copy link
Collaborator

TBH uncommenting lines can break easily if you update firejail.

@rusty-snake
Copy link
Collaborator

And 👍 for #COMMAND # COMMENT difference.

@kmk3
Copy link
Collaborator

kmk3 commented Aug 11, 2023

@glitsj16

Ah you beat me to it :p

I also started working on this with a script (I probably should have commented
about it on a related PR), though it's only for the # to # and fixing the
end-of-line comments (mostly no changes to existing normal comments).

It currently changes about ~220 files.

Do you mind if we try the automated way first and then continue with this PR
for whatever is missing?

@glitsj16
Copy link
Collaborator Author

glitsj16 commented Aug 11, 2023

And for #COMMAND # COMMENT difference.

@rusty-snake Thanks. There's bound to be plenty of places left were we could streamline this. Perhaps we can add an item in the template so it's a bit more explicit for anyone who contributes and cares to actually follow the template.

Do you mind if we try the automated way first and then continue with this PR
for whatever is missing?

@kmk3 Absolutely not, feel free to proceed with your scripted version 👍 .

@kmk3 kmk3 marked this pull request as draft August 12, 2023 06:07
@glitsj16
Copy link
Collaborator Author

glitsj16 commented Sep 6, 2023

Let's close this now that #5987 takes over.

@glitsj16 glitsj16 closed this Sep 6, 2023
@glitsj16 glitsj16 deleted the comm-improv branch September 6, 2023 10:08
@kmk3 kmk3 changed the title safeguard single line comments profiles: safeguard single line comments Sep 7, 2024
@kmk3 kmk3 added the duplicate This issue or pull request already exists label Sep 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicate This issue or pull request already exists
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants