profiles: support more msmtp configuration paths #6060
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kmk3
changed the title
kmk3
reviewed
Oct 22, 2023
Since version 1.8.6 msmtp supports per-user configuration at either
~/.msmtprc (already supported by firejail) or
`$XDG_CONFIG_HOME/msmtp/config`. System-wide support can be placed at
/etc/msmtprc.
This adds the missing paths to the relevant .inc and .profile files.
Note that `blacklist ${HOME}/.msmtprc` is present on both
disable-common.inc and disable-programs.inc, so the new paths are added
to both files.
References:
https://wiki.archlinux.org/title/Msmtp#Basic_setup
https://marlam.de/msmtp/msmtp.html#Configuration-files
kmk3
approved these changes
Oct 22, 2023
kmk3
added a commit
to kmk3/firejail
that referenced
this pull request
Oct 23, 2023
They are already present in disable-common.inc. Added in the following commits: * 6bf6d5e ("updated program files", 2016-12-02) / PR netblue30#951 * 4928019 ("various hardening (netblue30#3394)", 2020-05-02) * 2e2c232 ("profiles: support more msmtp configuration paths (netblue30#6060)", 2023-10-22) Misc: This was noticed on PR netblue30#6060.
kmk3
added a commit
to kmk3/firejail
that referenced
this pull request
Oct 24, 2023
They are already present in disable-common.inc. Added in the following commits: * 6bf6d5e ("updated program files", 2016-12-02) / PR netblue30#951 * 4928019 ("various hardening (netblue30#3394)", 2020-05-02) * 2e2c232 ("profiles: support more msmtp configuration paths (netblue30#6060)", 2023-10-22) Misc: This was noticed on PR netblue30#6060.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since version 1.8.6 msmtp supports per-user configuration at either
~/.msmtprc (already supported by firejail) or
$XDG_CONFIG_HOME/msmtp/config. System-wide support can be placed at/etc/msmtprc.
This adds the missing paths to the relevant .inc and .profile files.
Note that
blacklist ${HOME}/.msmtprcis present on bothdisable-common.inc and disable-programs.inc, so the new paths are added
to both files.
References:
https://wiki.archlinux.org/title/Msmtp#Basic_setup
https://marlam.de/msmtp/msmtp.html#Configuration-files