Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

firecfg: use ignorelist also for .profile/.desktop files #6153

Merged
merged 4 commits into from
Jan 19, 2024

Conversation

kmk3
Copy link
Collaborator

@kmk3 kmk3 commented Jan 11, 2024

Currently it is only used when parsing the configuration files:

  • /etc/firecfg.d/*.conf
  • /etc/firecfg.config

Use it when searching for .profile and .desktop files as well:

  • ~/.config/firejail/*.profile
  • /usr/share/applications/*.desktop

Closes #5245.

Relates to #5876.

Currently it is only used when parsing the configuration files:

* /etc/firecfg.d/*.conf
* /etc/firecfg.config

Use it when searching for profile filenames as well:

* ~/.config/firejail/*.profile

Relates to netblue30#5876.
Changes:

* Export `in_ignorelist` function
* Allow only building the ignorelist without setting the symlinks
* Rename the functions to reflect the above
* Add a function that parses all config files (`parse_config_all`)

Also, make sure that `parse_config_all` only parses config files once,
even if called multiple times.

Relates to netblue30#5876.
@kmk3 kmk3 merged commit 39fbb6b into netblue30:master Jan 19, 2024
13 checks passed
@kmk3 kmk3 deleted the firecfg-ignorelist-extra branch January 19, 2024 18:00
kmk3 added a commit that referenced this pull request Jan 20, 2024
kmk3 added a commit to kmk3/firejail that referenced this pull request Mar 8, 2024
Based on the discussion at netblue30#5063.

Misc: The `\&` is used to escape the dot in `.desktop` (see roff(7)).

Relates to netblue30#6153.
kmk3 added a commit to kmk3/firejail that referenced this pull request Mar 14, 2024
Based on the discussion at netblue30#5063.

Misc: The `\&` is used to escape the dot in `.desktop` (see roff(7)).

This amends commit a9c851e ("firecfg: use ignorelist also for .desktop
files", 2024-01-08) / PR netblue30#6153.
kmk3 added a commit that referenced this pull request Mar 14, 2024
Based on the discussion at #5063.

Misc: The `\&` is used to escape the dot in `.desktop` (see roff(7)).

This amends commit a9c851e ("firecfg: use ignorelist also for .desktop
files", 2024-01-08) / PR #6153.
@kmk3 kmk3 added the firecfg Anything related to firecfg and not firejail itself label Jul 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature request firecfg Anything related to firecfg and not firejail itself
Projects
Status: Done (on RELNOTES)
Development

Successfully merging this pull request may close these issues.

Firecfg still creates desktop files despite being disabled in firecfg.config
2 participants