-
Notifications
You must be signed in to change notification settings - Fork 569
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New profile: tqemu #6255
New profile: tqemu #6255
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is the profile for a qemu wrapper in some cases more restrictive than the
profile for qemu itself (qemu-system-x86_64.profile
)?
Suggestions:
- Move the contents of
qemu-system-x86_64.profile
intoqemu-common.profile
and make the former (andqemu-launcher.profile
) redirect to the latter - Make
tqemu.profile
redirect toqemu-common.profile
- Harden
qemu-common.profile
(preferably in another PR as it may cause
breakage for qemu itself)
AFAIK tqemu is the only such wrapper that doesn't rely on libvirt. It's more limited in its functionality, but that also makes it very straightforward to sandbox. I'll need more time to refactor/double-check the qemu wrappers as you suggested. Thanks! |
That's good to know, but qemu itself does not use libvirt (it's essentially the My point was that in general it doesn't make much sense for a wrapper (tqemu)
On second though, for simplicity, I'd just copy and paste most of |
Done! |
Description: QEMU frontend without libvirt. https://github.com/thanoulis/tqemu
Add a common profile to deduplicate entries and make qemu-related profiles redirect to it. Relates to netblue30#6255.
Add a common profile to deduplicate entries and make qemu-related profiles redirect to it. Relates to netblue30#6255.
Add a common profile to deduplicate entries and make qemu-related profiles redirect to it. Relates to #6255.
tqemu
Description: QEMU frontend without libvirt.
https://github.com/thanoulis/tqemu