build: fix "warning: "_FORTIFY_SOURCE" redefined" #6283
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glitsj16
approved these changes
Mar 19, 2024
The warning is being produced on Arch since pacman 6.1, which changed
`-D_FORTIFY_SOURCE=2` to `-D_FORTIFY_SOURCE=3` in CFLAGS in
makepkg.conf:
$ pacman -Q gcc pacman
gcc 13.2.1-5
pacman 6.1.0-3
$ makepkg
[...]
make -C src/lib
gcc [...] -D_FORTIFY_SOURCE=2 [...] -Wp,-D_FORTIFY_SOURCE=3 [...] -c ../../src/lib/common.c -o ../../src/lib/common.o
<command-line>: warning: "_FORTIFY_SOURCE" redefined
<command-line>: note: this is the location of the previous definition
To fix this, only add `-D_FORTIFY_SOURCE` to EXTRA_CFLAGS if it does not
cause any warnings with CFLAGS and CPPFLAGS during compilation.
The effect remains the same: The build system still defines the macro by
default (if there are no warnings) and the user/distribution can still
override it through CFLAGS/CPPFLAGS.
Fixes netblue30#6282.
Reported-by: @glitsj16
kmk3
force-pushed
the
build-fix-fortify-warn
branch
from
bd5c8ad to
bce208d
Compare
kmk3
added a commit
that referenced
this pull request
Mar 25, 2024
kmk3
added a commit
to kmk3/firejail
that referenced
this pull request
Mar 26, 2024
If not, build with -D_FORTIFY_SOURCE=2 if available (this is what is currently done). Note: `-D_FORTIFY_SOURCE=3` is the new default on Arch; see commit 0da23da ("build: fix "warning: "_FORTIFY_SOURCE" redefined" (netblue30#6283)", 2024-03-20). This is a follow-up to netblue30#6283.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The warning is being produced on Arch since pacman 6.1, which changed
-D_FORTIFY_SOURCE=2to-D_FORTIFY_SOURCE=3in CFLAGS inmakepkg.conf:
To fix this, only add
-D_FORTIFY_SOURCEto EXTRA_CFLAGS if it does notcause any warnings with CFLAGS and CPPFLAGS during compilation.
The effect remains the same: The build system still defines the macro by
default (if there are no warnings) and the user/distribution can still
override it through CFLAGS/CPPFLAGS.
Fixes #6282.
Reported-by: @glitsj16