-
-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added redirect to pull non-existant local assets from live_endpoint url #70
base: master
Are you sure you want to change the base?
Conversation
Seemed to work, but I notice it seems to have issues with the assets that contain a part2 file. It only downloads the first part if not found locally but fails on the second part. |
Weird, wasnt an issue for me, specifically tested for it:
(remote):
@antonym Which image did you test with, maybe I can replicate/debug? |
Related but tangential. Hope that's ok... If I wanted to test this using netboot.xyz running in Docker Compose would it be sufficient to just pull the branch and then use the docker-compose.yml.example? I suspect I might also have to modify the image name also? Or just do a EDIT: Yes, changing to the PR branch and rebuilding the image with the same tag/name worked. |
I tried this out and it worked fine. Any word on pulling this? @antonym |
Tested with the Ubuntu 22.04 Image (Gnome), with endpoint set to local machine and cache downloaded:
Removed cache, and attempted, dumps to busy box after the first image pull, doesn't seem to handle the redirect for part2 or part3 checks correctly:
After it pulls the first squashfs part, it dumps to busy box. Also noticed that the generation of the config file was squashing the variables with |
Fix for the vars in this commit getting squashed during new deploy: #78 |
This PR implements #69
It achieves that the nginx can serve local assets as before, but it will send HTTP 302 redirects to the standard live_endpoint url for files that are NOT found locally.