Upgrade go-netbox to Netbox version 3.0.2 #121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/cc @awlx :D |
|
@chdxD1 thanks for your PR :). Is it good to merge from your perspective or anything you'd like to add before we merge it? |
|
@awlx is the failing go 1.16.x check something to worry about? I've tried to replicate it locally with a clean 1.16 docker container but there it worked fine. |
|
I don't think it's something to worry about as it fails for everything ... and I didn't figure out yet why this happens. Also it's only 1.16. |
awlx
approved these changes
Sep 16, 2021
|
https://github.com/netbox-community/go-netbox/releases/tag/netbox_v3.0 released! Thanks again @chdxD1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is my first PR here but I hope that this is fine!
This PR tries to update this library to Netbox version 3.0.2. There are some changes however from the official swagger.json file that can be fetched from a Netbox:
swagger generate clientgenerates it in a scientific notation which does not work with go"additionalProperties": {"type": "string", "x-nullable": true}. This will result in a map ofinterface{}instead of the correct nested types. Swagger does not really support discriminators on the same level (like connected_endpoint_type / cable_peer_type) apparently. However the connected_endpoint and cable_peer_type can vary. Also some nested types are missing (e.g. for console ports).I think the swagger autogeneration on the netbox side itself also needs some love to not require these changes but it's something someone needs to take care off (netbox-community/netbox#4808, netbox-community/netbox#4804)