Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor imports for extras.forms.mixins #12919

Closed
arthanson opened this issue Jun 16, 2023 · 2 comments
Closed

Refactor imports for extras.forms.mixins #12919

arthanson opened this issue Jun 16, 2023 · 2 comments
Labels
status: accepted This issue has been accepted for implementation type: housekeeping Changes to the application which do not directly impact the end user

Comments

@arthanson
Copy link
Collaborator

Proposed Changes

Refactor imports for extras.forms.mixins, specifically in netbox.forms.base.py it has an import of:

from extras.forms.mixins import CustomFieldsMixin, SavedFiltersMixin

if extras.admin.py doesn't have the following import:

from .forms import ConfigRevisionForm

There will be a circular import error.

Justification

items in netbox should not be calling into sub-packages if at all possible, any required forms and such should be factored out to utilities or netbox to prevent circular import issues.

@arthanson arthanson added the type: housekeeping Changes to the application which do not directly impact the end user label Jun 16, 2023
@github-actions
Copy link
Contributor

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. NetBox is governed by a small group of core maintainers which means not all opened issues may receive direct feedback. Do not attempt to circumvent this process by "bumping" the issue; doing so will result in its immediate closure and you may be barred from participating in any future discussions. Please see our contributing guide.

@github-actions github-actions bot added the pending closure Requires immediate attention to avoid being closed for inactivity label Sep 15, 2023
@jeremystretch jeremystretch added status: accepted This issue has been accepted for implementation and removed pending closure Requires immediate attention to avoid being closed for inactivity labels Oct 6, 2023
@jeremystretch
Copy link
Member

This appears to have been addressed under #14326.

@jeremystretch jeremystretch closed this as not planned Won't fix, can't repro, duplicate, stale Jan 5, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
status: accepted This issue has been accepted for implementation type: housekeeping Changes to the application which do not directly impact the end user
Projects
None yet
Development

No branches or pull requests

2 participants