Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move form feature mixin classes from extras to netbox #14326

Closed
jeremystretch opened this issue Nov 22, 2023 · 0 comments
Closed

Move form feature mixin classes from extras to netbox #14326

jeremystretch opened this issue Nov 22, 2023 · 0 comments
Assignees
@jeremystretch
Labels
status: accepted This issue has been accepted for implementation type: housekeeping Changes to the application which do not directly impact the end user
Milestone
v3.7

Comments

@jeremystretch
Copy link
Member

Proposed Changes

Move the following classes from extras.forms.mixins to netbox.forms.mixins:

  • CustomFieldsMixin
  • SavedFiltersMixin
  • TagsMixin

Justification

This will clean up the form hierarchy a bit, and help avoid circular imports. We currently have a hack in place specifically to avoid this:

netbox/netbox/extras/admin.py

Lines 1 to 2 in d52a6d3

# TODO: Removing this import triggers an import loop due to how form mixins are currently organized
from .forms import ConfigRevisionForm

Additionally, it has come up again during work on #14312.
@jeremystretch jeremystretch added status: accepted This issue has been accepted for implementation type: housekeeping Changes to the application which do not directly impact the end user labels Nov 22, 2023
@jeremystretch jeremystretch added this to the v3.7 milestone Nov 22, 2023
@jeremystretch jeremystretch self-assigned this Nov 22, 2023
@jeremystretch jeremystretch mentioned this issue Nov 22, 2023
Merged
jeremystretch added a commit that referenced this issue Nov 22, 2023
@jeremystretch
Closes #14326: Move form mixins (#14327)
18422e1 
* Move form mixins from extras app to netbox app

* Remove obsolete extras/admin.py
@jeremystretch jeremystretch mentioned this issue Dec 29, 2023
Merged
@jeremystretch jeremystretch mentioned this issue Jan 5, 2024
Closed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jeremystretch jeremystretch

Labels
status: accepted This issue has been accepted for implementation type: housekeeping Changes to the application which do not directly impact the end user
Projects
None yet
Milestone
v3.7
Development

No branches or pull requests
1 participant
@jeremystretch