Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Usage of Comma in Custom Links not possible #13011

Closed
v0tti opened this issue Jun 26, 2023 · 1 comment · Fixed by #13018
Closed

Usage of Comma in Custom Links not possible #13011

v0tti opened this issue Jun 26, 2023 · 1 comment · Fixed by #13018
Assignees
@v0tti
Labels
severity: low Does not significantly disrupt application functionality, or a workaround is available status: accepted This issue has been accepted for implementation type: bug A confirmed report of unexpected behavior in the application

Comments

@v0tti
Copy link
Contributor

v0tti commented Jun 26, 2023

NetBox version

v3.5.2

Python version

3.10

Steps to Reproduce

  1. Create Custom Link
  2. Enter https://www.tim-online.nrw.de/tim-online2/?center={{ object.latitude }},{{ object.longitude }}&icon=true as Link URL

Expected Behavior

I would expect the comma character in the center= parameter to be rendered as a comma (,).

Observed Behavior

The comma gets replaced with %2C.
The map service we are using does not show the location because it needs a comma character between longitude and latitude in order to display.
@v0tti v0tti added the type: bug A confirmed report of unexpected behavior in the application label Jun 26, 2023
@v0tti
Copy link
Contributor Author

v0tti commented Jun 26, 2023

I would be happy to open a PR that's fixing this by adding the comma character to the list of excluded characters for URL safe encoding if this gets accepted.

@DanSheps DanSheps added the status: accepted This issue has been accepted for implementation label Jun 26, 2023
@DanSheps DanSheps added the severity: low Does not significantly disrupt application functionality, or a workaround is available label Jun 26, 2023
@v0tti v0tti mentioned this issue Jun 27, 2023
Merged
jeremystretch pushed a commit that referenced this issue Jun 27, 2023
@v0tti @jeremystretch
Fixes #13011: Allow comma in custom links
f1858a7
jeremystretch added a commit that referenced this issue Jun 27, 2023
@jeremystretch
Changelog for #12849, #12945, #12961, #12977, #12983, #13011
6b01b1d
@jeremystretch jeremystretch mentioned this issue Jul 6, 2023
Merged
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@v0tti v0tti

Labels
severity: low Does not significantly disrupt application functionality, or a workaround is available status: accepted This issue has been accepted for implementation type: bug A confirmed report of unexpected behavior in the application
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixes #13011: Allow comma in custom links
2 participants
@v0tti @DanSheps