Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reports: Status is "Completed" even if the Report contains failure messages #13369

Closed
AHo-27 opened this issue Aug 3, 2023 · 0 comments · Fixed by #13371
Closed

Reports: Status is "Completed" even if the Report contains failure messages #13369

AHo-27 opened this issue Aug 3, 2023 · 0 comments · Fixed by #13371
Assignees
Labels
status: accepted This issue has been accepted for implementation type: bug A confirmed report of unexpected behavior in the application

Comments

@AHo-27
Copy link

AHo-27 commented Aug 3, 2023

NetBox version

v3.5.7

Python version

3.9

Steps to Reproduce

  1. Create a Report which logs a failure,
    Example report file 'report_status_test.py':
from extras.reports import Report

class TestReportStatus(Report):
    description = "test report status"

    def test_report_status(self):
        self.log_info(None, "info")
        self.log_success(None, "check passed")
        self.log_failure(None, "check failed")
  1. Add the report module to netbox
  2. Go the "Reports" and run the Report
  3. Check the Report Status/Results

Expected Behavior

If a Report contains failure messages, I would expect the Report status to be "Failed". (as it was the case with older Netbox versions)

Observed Behavior

The Report status is "Completed" instead of "Failed"
At first sight it looks to the user as if the report is successful.
grafik

@AHo-27 AHo-27 added the type: bug A confirmed report of unexpected behavior in the application label Aug 3, 2023
@jeremystretch jeremystretch added the status: accepted This issue has been accepted for implementation label Aug 3, 2023
@jeremystretch jeremystretch self-assigned this Aug 3, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
status: accepted This issue has been accepted for implementation type: bug A confirmed report of unexpected behavior in the application
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants