Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sentry SDK should be an optional package #13645

Closed
jeremystretch opened this issue Aug 31, 2023 · 0 comments
Closed

Sentry SDK should be an optional package #13645

jeremystretch opened this issue Aug 31, 2023 · 0 comments
Assignees
@jeremystretch
Labels
status: accepted This issue has been accepted for implementation type: feature Introduction of new functionality to the application
Milestone
v3.7

Comments

@jeremystretch
Copy link
Member

NetBox version

v3.6.0

Feature type

Change to existing functionality

Proposed functionality

NetBox supports error reporting via integration with Sentry as an optional feature, however sentry-sdk is currently a required package. It should be made optional. (This is similar to what we did for boto3 in #12906.)

Use case

This library is only needed if the Sentry integration is enabled.

Database changes

N/A

External dependencies

N/A
@jeremystretch jeremystretch added type: feature Introduction of new functionality to the application status: needs owner This issue is tentatively accepted pending a volunteer committed to its implementation labels Aug 31, 2023
@jeremystretch jeremystretch added status: accepted This issue has been accepted for implementation and removed status: needs owner This issue is tentatively accepted pending a volunteer committed to its implementation labels Nov 6, 2023
@jeremystretch jeremystretch added this to the v3.7 milestone Nov 6, 2023
@jeremystretch jeremystretch self-assigned this Nov 6, 2023
jeremystretch added a commit that referenced this issue Nov 6, 2023
@jeremystretch
Closes #13645: Make Sentry integration optional
9127383
@jeremystretch jeremystretch mentioned this issue Nov 6, 2023
Merged
jeremystretch added a commit that referenced this issue Nov 9, 2023
@jeremystretch
Closes #13645: Make Sentry integration optional
f48f6a1
jeremystretch added a commit that referenced this issue Nov 9, 2023
@jeremystretch
Closes #13645: Make Sentry integration optional
21a9d16
jeremystretch added a commit that referenced this issue Nov 9, 2023
@jeremystretch
Closes #13645: Make Sentry integration optional (#14197)
840b7d8
@jeremystretch jeremystretch mentioned this issue Dec 29, 2023
Merged
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jeremystretch jeremystretch

Labels
status: accepted This issue has been accepted for implementation type: feature Introduction of new functionality to the application
Projects
None yet
Milestone
v3.7
Development

No branches or pull requests
1 participant
@jeremystretch