Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add the ability to pass classes to the copy button #14390

Closed
abhi1693 opened this issue Nov 30, 2023 · 0 comments · Fixed by #14391
Closed

Add the ability to pass classes to the copy button #14390

abhi1693 opened this issue Nov 30, 2023 · 0 comments · Fixed by #14391
Assignees
@abhi1693
Labels
status: accepted This issue has been accepted for implementation type: feature Introduction of new functionality to the application

Comments

@abhi1693
Copy link
Member

NetBox version

v3.6.6

Feature type

Change to existing functionality

Proposed functionality

Add an optional parameter to the copy_button method to allow for passing additional classes.

Use case

Pass d-none class to the element to programatically show and hide the copy button based on a condition.

Related bug report: Onemind-Services-LLC/netbox-secrets#104

Database changes

No response

External dependencies

No response
@abhi1693 abhi1693 added the type: feature Introduction of new functionality to the application label Nov 30, 2023
abhi1693 added a commit that referenced this issue Nov 30, 2023
@abhi1693
adds optional classes parameter #14390
674ddf7
@abhi1693 abhi1693 mentioned this issue Nov 30, 2023
Merged
@jeremystretch jeremystretch added the status: accepted This issue has been accepted for implementation label Dec 5, 2023
jeremystretch pushed a commit that referenced this issue Dec 5, 2023
@abhi1693 @jeremystretch
adds optional classes parameter #14390
b21ed6a
jeremystretch added a commit that referenced this issue Dec 7, 2023
@jeremystretch
Changelog for #14249, #14390, #14392, #14397, #14401, #14432, #14448
2ef023a
@jeremystretch jeremystretch mentioned this issue Dec 15, 2023
Merged
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@abhi1693 abhi1693

Labels
status: accepted This issue has been accepted for implementation type: feature Introduction of new functionality to the application
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Adds optional classes parameter netbox-community/netbox
2 participants
@abhi1693 @jeremystretch