Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove ChangeLoggedModel from StagedChange #14424

Closed
arthanson opened this issue Dec 4, 2023 · 0 comments
Closed

Remove ChangeLoggedModel from StagedChange #14424

arthanson opened this issue Dec 4, 2023 · 0 comments
Assignees
@arthanson
Labels
status: accepted This issue has been accepted for implementation type: deprecation Removal of existing functionality or behavior
Milestone
v3.7

Comments

@arthanson
Copy link
Collaborator

Proposed Changes

Remove ChangeLoggedModel mixin from the StagedChange model. Marking this as a deprecation as it would remove functionality.

Justification

As per #13640 When doing staged change API it can result in numerous ChangeLoggedModels being produced - For example when ingesting some customer information using the staging method there can be up to 100k+ objects being altered. Deleting these takes very long due to the ChangeLoggedModel process.

Impact

Would regress in that no more ChangeLoggedModels would be produced for StagedChanges.
@arthanson arthanson added the type: deprecation Removal of existing functionality or behavior label Dec 4, 2023
@arthanson arthanson mentioned this issue Dec 4, 2023
Closed
@jeremystretch jeremystretch added the status: under review Further discussion is needed to determine this issue's scope and/or implementation label Dec 5, 2023
@arthanson arthanson self-assigned this Dec 7, 2023
@arthanson arthanson mentioned this issue Dec 8, 2023
Merged
@arthanson arthanson added status: accepted This issue has been accepted for implementation and removed status: under review Further discussion is needed to determine this issue's scope and/or implementation labels Dec 8, 2023
@jeremystretch jeremystretch added this to the v3.7 milestone Dec 11, 2023
jeremystretch added a commit that referenced this issue Dec 15, 2023
@jeremystretch
Changelog for #14147, #14424, #14436, #14458
3068f2a
@jeremystretch jeremystretch mentioned this issue Dec 29, 2023
Merged
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@arthanson arthanson

Labels
status: accepted This issue has been accepted for implementation type: deprecation Removal of existing functionality or behavior
Projects
None yet
Milestone
v3.7
Development

No branches or pull requests
2 participants
@arthanson @jeremystretch