Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Importing IKE proposal without authentication method is not possible #14817

Closed
markkuleinio opened this issue Jan 17, 2024 · 2 comments · Fixed by #14821
Closed

Importing IKE proposal without authentication method is not possible #14817

markkuleinio opened this issue Jan 17, 2024 · 2 comments · Fixed by #14821
Assignees
Labels
severity: medium Results in substantial degraded or broken functionality for specfic workflows status: accepted This issue has been accepted for implementation type: bug A confirmed report of unexpected behavior in the application

Comments

@markkuleinio
Copy link
Contributor

Deployment Type

Self-hosted

NetBox Version

v3.7.0

Python Version

3.11

Steps to Reproduce

Go to VPN - IKE Proposals - Add

  1. Name = GUITEST
  2. Authentication method = PSK
  3. Encryption algorithm = 256-bit AES (GCM)
  4. Group = Group 20
  5. Create

(= is successful)

Go to VPN - IKE Proposals - Import, use the same fields as above:

name,authentication_method,encryption_algorithm,group
IMPORTTEST,preshared-keys,aes-256-gcm,20

Expected Behavior

IKE proposal is imported successfully.

Observed Behavior

Error is shown:

Record 1 authentication_algorithm: This field is required.

In the import field options the authentication_algorithm field is shown as required even though it is not required in GUI.

Also, in the authentication_algorithm value list there is no "empty" option to use, thus it is not possible to import IKE proposals that use GCM, unless you fake the algorithm during the import.

Also note that if authentication algorithm is nevertheless set and you want to remove it, you have to single-edit the proposal: it is not possible to select all proposals in the list and use Edit Selected, as it is not possible to clear the field there.

Related to #14499 where GUI requirement for the authentication method was relaxed.

@markkuleinio markkuleinio added the type: bug A confirmed report of unexpected behavior in the application label Jan 17, 2024
@jeremystretch
Copy link
Member

Seems like this was an oversight during the work on #14499.

@jeremystretch jeremystretch added status: needs owner This issue is tentatively accepted pending a volunteer committed to its implementation severity: medium Results in substantial degraded or broken functionality for specfic workflows labels Jan 17, 2024
@jeremystretch
Copy link
Member

A similar discrepancy exists with the encryption_algorithm and authentication_algorithm fields on the IPSec proposal bulk import form.

@jeremystretch jeremystretch self-assigned this Jan 17, 2024
@jeremystretch jeremystretch added status: accepted This issue has been accepted for implementation and removed status: needs owner This issue is tentatively accepted pending a volunteer committed to its implementation labels Jan 17, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
severity: medium Results in substantial degraded or broken functionality for specfic workflows status: accepted This issue has been accepted for implementation type: bug A confirmed report of unexpected behavior in the application
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants