Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cable type empty filtering not working #16837

Closed
betadrome opened this issue Jul 8, 2024 · 3 comments · Fixed by #17574
Closed

Cable type empty filtering not working #16837

betadrome opened this issue Jul 8, 2024 · 3 comments · Fixed by #17574
Assignees
@bctiemann
Labels
severity: low Does not significantly disrupt application functionality, or a workaround is available status: accepted This issue has been accepted for implementation type: bug A confirmed report of unexpected behavior in the application

Comments

@betadrome
Copy link

Deployment Type

Self-hosted

NetBox Version

v.4.0.6

Python Version

3.11

Steps to Reproduce

  1. Go to https://netbox.example.com/dcim/cables/
  2. Filter type__empty=True (https://netbox.example.com/dcim/cables/?type__empty=True)
  3. Filter is not working

Expected Behavior

Only shows Cables without type

Observed Behavior

Filter shows all cables, seems like nothing was filtered
@betadrome betadrome added status: needs triage This issue is awaiting triage by a maintainer type: bug A confirmed report of unexpected behavior in the application labels Jul 8, 2024
@betadrome
Copy link
Author

As this filtering is quite important to me, I tried again and found that the following works for me: https://netbox.example.com/dcim/cables/?type__n=cat3&type__n=cat5&type__n=cat5e&type__n=cat6&type__n=cat6a&type__n=cat7&type__n=cat7a&type__n=cat8&type__n=dac-active&type__n=dac-passive&type__n=mrj21-trunk&type__n=coaxial&type__n=mmf&type__n=mmf-om1&type__n=mmf-om2&type__n=mmf-om3&type__n=mmf-om4&type__n=mmf-om5&type__n=smf&type__n=smf-os1&type__n=smf-os2&type__n=aoc&type__n=power. Should the other spelling be possible in the future, it would still be quite helpful, but for now its fine for me!

@arthanson arthanson added status: needs owner This issue is tentatively accepted pending a volunteer committed to its implementation severity: low Does not significantly disrupt application functionality, or a workaround is available and removed status: needs triage This issue is awaiting triage by a maintainer labels Jul 9, 2024
@arthanson arthanson removed their assignment Jul 9, 2024
@arthanson
Copy link
Collaborator

Potentially needs: https://django-filter.readthedocs.io/en/main/guide/tips.html#filtering-by-an-empty-string

@bctiemann bctiemann added status: accepted This issue has been accepted for implementation and removed status: needs owner This issue is tentatively accepted pending a volunteer committed to its implementation labels Sep 12, 2024
@bctiemann bctiemann self-assigned this Sep 12, 2024
@bctiemann bctiemann mentioned this issue Sep 12, 2024
Closed
@bctiemann bctiemann mentioned this issue Sep 23, 2024
Merged
jeremystretch pushed a commit that referenced this issue Sep 24, 2024
@bctiemann
Closes: #16837 - Fix type__empty filter in character-based filters (#…
116a423 
…17574)

* Fix type__empty filter in character-based filters

* Add tests
@jeremystretch jeremystretch mentioned this issue Sep 26, 2024
Merged
@betadrome
Copy link
Author

Hey, thanks for adding this feature/fixing this bug! It works as expected!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bctiemann bctiemann

Labels
severity: low Does not significantly disrupt application functionality, or a workaround is available status: accepted This issue has been accepted for implementation type: bug A confirmed report of unexpected behavior in the application
Projects
None yet
Milestone
No milestone
3 participants
@arthanson @bctiemann @betadrome