Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Table Issues #16850

Open
3 of 6 tasks
andrewgormley opened this issue Jul 8, 2024 · 4 comments
Open
3 of 6 tasks

Table Issues #16850

andrewgormley opened this issue Jul 8, 2024 · 4 comments
Labels
netbox status: backlog Awaiting selection for work topic: UI/UX User interface or user experience related work type: feature Introduction of new functionality to the application

Comments

@andrewgormley
Copy link
Contributor

andrewgormley commented Jul 8, 2024

NetBox version

v4.1.0-dev

Feature type

Change to existing functionality

Proposed functionality

  • (Misc) Checkbox missing label [Multiple]
  • (Misc) Missing link text on hidden table column [Multiple]
  • (Tables) unlabelled column header for checkbox column [Multiple]
  • (Tables) Ensure tables use table and row headers to describe cells [Multiple]
  • (Tables) Row actions missing accessible names [Multiple]
  • (Tables) When table column is sorted the 'x' icon is missing link text [Multiple]

Use case

Fixing web accessibility issues ensures NetBox is best placed to serve users using screen readers and other accessibility tools.

Database changes

No response

External dependencies

No response

@andrewgormley andrewgormley added type: feature Introduction of new functionality to the application topic: UI/UX User interface or user experience related work labels Jul 8, 2024
@andrewgormley andrewgormley added this to the v4.1 milestone Jul 8, 2024
@andrewgormley andrewgormley self-assigned this Jul 8, 2024
@jeremystretch jeremystretch added the status: accepted This issue has been accepted for implementation label Jul 15, 2024
@andrewgormley
Copy link
Contributor Author

  • (Misc) Missing link text on hidden table column [Multiple]
  • (Tables) unlabelled column header for checkbox column [Multiple]

These two issues appear to be related to the actions column, the missing link is due to the sortable option being set to true even though there is no label. I believe to fix both issues we should set the sortable option to false and label the column as 'actions' or similar.

Screenshot 2024-07-24 at 12 06 02

@andrewgormley
Copy link
Contributor Author

  • (Misc) Checkbox missing label [Multiple]

This issue is due to the checkbox not having an associated label, however being in a table this is a bit of an edge case, this might be fixable with an aria label

Screenshot 2024-07-24 at 12 06 47

@andrewgormley
Copy link
Contributor Author

I've moved more table issues from #16852 to here.

andrewgormley pushed a commit to andrewgormley/netbox that referenced this issue Jul 25, 2024
jeremystretch added a commit that referenced this issue Aug 1, 2024
* fixes issues in #16850: issue 3 and 5

* Add link text for 'clear' button on table column

* Translate aria label

---------

Co-authored-by: Andrew Gormley <Andrew@MacBook-Pro-3.local>
Co-authored-by: Jeremy Stretch <jstretch@netboxlabs.com>
@jeremystretch
Copy link
Member

Some of the above items (checked) were addressed in PR #16986.

jeremystretch added a commit that referenced this issue Aug 2, 2024
* 16649 general contrast issues (#16759)

* fixes #16647: navigation contrast issues updated

* fixes #16651: table contrast issues new

* fixed #16649: general contrast issues

* fixes #16649: feedback changes

---------

Co-authored-by: Andrew Gormley <Andrew@MacBook-Pro-3.local>
Co-authored-by: Andrew Gormley <Andrew@MacBook-Pro-3.broadband>

* 16648 dashboard contrast issues (#16824)

* fixed #16648: dashboard contrast issues

* reinstate amendment to 16649

* fixed #16648: created gridstack override and removed inline bug fix

---------

Co-authored-by: Andrew Gormley <Andrew@MacBook-Pro-3.local>

* fixed #16853: accessibility issues

* fixed #16847: updated font (#16848)

* fixed #16847: updated font

* fixed #16847: changed font to local and added current font as fallback

* fixed #16847: removed inter and added padding to page header

---------

Co-authored-by: Andrew Gormley <Andrew@MacBook-Pro-3.local>
Co-authored-by: Jeremy Stretch <jstretch@netboxlabs.com>

* 16849 document hierarchy issues (#16875)

* fixed #16849: h elements not in sequential order

* fixed #16849: Lists do not contain only li elements

* fixed #16849: fixed h hierarchy on rack object pages

* Remove standalone h5 classes

* Remove unnecessary line breaks

---------

Co-authored-by: Andrew Gormley <Andrew@MacBook-Pro-3.local>
Co-authored-by: Jeremy Stretch <jstretch@netboxlabs.com>

* 16650 button contrast issues (#16845)

* fixed #16650: button contrast issues

* fixed #16650: green bg text contrast issue

* Revert errant JS resource updates

* Revert custom button colors

* Fix indentation

---------

Co-authored-by: Andrew Gormley <Andrew@MacBook-Pro-3.local>
Co-authored-by: Jeremy Stretch <jstretch@netboxlabs.com>

* 16907 web UI refresh (#16915)

* closes #16907: web ui refresh

* closes #16907: changed default widget color to primary color

* closes #16907: removed comma

* Revert dashboard widget color changes

* Rename logo images for consistency

* Restore original dashboard widget config

* Remove .navbar-brand-autodark from logo

* Restore logo file names

---------

Co-authored-by: Andrew Gormley <Andrew@MacBook-Pro-3.local>
Co-authored-by: Jeremy Stretch <jstretch@netboxlabs.com>

* 16394 distinguish product edition (#16924)

* closes #16907: web ui refresh

* closes #16907: changed default widget color to primary color

* closes #16907: removed comma

* closes #16394: distinguish product edition

* Revert dashboard changes

* Clean up redundant styling (merge error)

* removed labs logo and added sub text for all editions

* fixed motif bug

* Fix "flashing" of side nav under dark mode

* Use title case for edition label

* altered edition text style

---------

Co-authored-by: Andrew Gormley <Andrew@MacBook-Pro-3.local>
Co-authored-by: Jeremy Stretch <jstretch@netboxlabs.com>

* Query release features to toggle commercial theme

* fixes dark mode primary button contrast issue

* fixes #16913: hidden admin nav link (#16978)

Co-authored-by: Andrew Gormley <Andrew@MacBook-Pro-3.local>
Co-authored-by: Jeremy Stretch <jstretch@netboxlabs.com>

* fixed 16852: misc accessbility problems (#16977)

* fixed 16852: misc accessbility problems

* Restore tooltip text

* Add translation support

* Add missing i18n

---------

Co-authored-by: Andrew Gormley <Andrew@MacBook-Pro-3.local>
Co-authored-by: Jeremy Stretch <jstretch@netboxlabs.com>

* fixes issues in #16850 (#16986)

* fixes issues in #16850: issue 3 and 5

* Add link text for 'clear' button on table column

* Translate aria label

---------

Co-authored-by: Andrew Gormley <Andrew@MacBook-Pro-3.local>
Co-authored-by: Jeremy Stretch <jstretch@netboxlabs.com>

* Use alternate footer links for commercial releases

* Remove Inter font

* Adjust base font weight to 500

* Retain default text color for hyperlinks inside tables

* Logo & edition cleanup

* Move dashboard styling

* Misc cleanup

* Remove unused styles

* Misc cleanup & refactoring

---------

Co-authored-by: Andrew Gormley <andrewgormley91@gmail.com>
Co-authored-by: Andrew Gormley <Andrew@MacBook-Pro-3.local>
Co-authored-by: Andrew Gormley <Andrew@MacBook-Pro-3.broadband>
@jeremystretch jeremystretch added status: backlog Awaiting selection for work and removed status: accepted This issue has been accepted for implementation labels Aug 29, 2024
@jeremystretch jeremystretch removed this from the v4.1 milestone Aug 29, 2024
@jeremystretch jeremystretch added the netbox label Nov 1, 2024 — with Linear
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
netbox status: backlog Awaiting selection for work topic: UI/UX User interface or user experience related work type: feature Introduction of new functionality to the application
Projects
None yet
Development

No branches or pull requests

2 participants