Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop contact_* fields from dcim.Site #7748

Closed
jeremystretch opened this issue Nov 4, 2021 · 2 comments
Closed

Drop contact_* fields from dcim.Site #7748

jeremystretch opened this issue Nov 4, 2021 · 2 comments
Assignees
Labels
status: accepted This issue has been accepted for implementation type: deprecation Removal of existing functionality or behavior
Milestone

Comments

@jeremystretch
Copy link
Member

Proposed Changes

Remove the following fields from the dcim.Site model:

  • contact_name
  • contact_phone
  • contact_email

Justification

NetBox v3.1 introduced a new Contact model (see #1344), which supports the more efficient assignment of contacts to sites and other objects, obviating the need for these fields on the model.

@jeremystretch jeremystretch added status: accepted This issue has been accepted for implementation type: deprecation Removal of existing functionality or behavior labels Nov 4, 2021
@jeremystretch jeremystretch added this to the v3.2 milestone Nov 4, 2021
@cs-1
Copy link

cs-1 commented Nov 5, 2021

Will the upgrade script migrate existing contacts from sites to the new Contact model?

@jeremystretch
Copy link
Member Author

I wasn't comfortable including an automatic migration for existing contact data, given the largely free-form nature of the fields. However, we could publish a script to take care of this for users. It would allow users to perform a "dry-run" before committing the new objects.

@jeremystretch jeremystretch self-assigned this Dec 9, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
status: accepted This issue has been accepted for implementation type: deprecation Removal of existing functionality or behavior
Projects
None yet
Development

No branches or pull requests

2 participants