Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert IntegerFields used by generic foreign keys to BigIntegerFields #8195

Closed
jeremystretch opened this issue Dec 30, 2021 · 0 comments
Closed

Convert IntegerFields used by generic foreign keys to BigIntegerFields #8195

jeremystretch opened this issue Dec 30, 2021 · 0 comments
Assignees
@jeremystretch
Labels
status: accepted This issue has been accepted for implementation type: housekeeping Changes to the application which do not directly impact the end user
Milestone
v3.2

Comments

@jeremystretch
Copy link
Member

Proposed Changes

Some time ago, we converted the default primary key for all NetBox models to 64-bit BigAutoFields (a derivative of BigIntegerField). However, we did not do the same for integer fields which are used as part of a GenericForeignKey reference. These fields also need to be converted.

Justification

This ensures that the GenericForeignKey relationships continue to function normally in the unlikely event that a user exceeds the maximum value of PositiveIntegerField.
@jeremystretch jeremystretch added type: housekeeping Changes to the application which do not directly impact the end user status: under review Further discussion is needed to determine this issue's scope and/or implementation labels Dec 30, 2021
@jeremystretch jeremystretch added status: accepted This issue has been accepted for implementation and removed status: under review Further discussion is needed to determine this issue's scope and/or implementation labels Jan 14, 2022
@jeremystretch jeremystretch self-assigned this Jan 14, 2022
@jeremystretch jeremystretch added this to the v3.2 milestone Jan 14, 2022
jeremystretch added a commit that referenced this issue Jan 24, 2022
@jeremystretch
Closes #8195: Ensure all GenericForeignKey ID fields employ PositiveB…
571e980 
…igIntegerField
This was referenced Apr 5, 2022
Closed
Merged
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jeremystretch jeremystretch

Labels
status: accepted This issue has been accepted for implementation type: housekeeping Changes to the application which do not directly impact the end user
Projects
None yet
Milestone
v3.2
Development

No branches or pull requests
1 participant
@jeremystretch