Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exception when search for rack position without defining a rack #8866

Closed
rodvand opened this issue Mar 14, 2022 · 1 comment · Fixed by #8870
Closed

Exception when search for rack position without defining a rack #8866

rodvand opened this issue Mar 14, 2022 · 1 comment · Fixed by #8870
Labels
status: accepted This issue has been accepted for implementation type: bug A confirmed report of unexpected behavior in the application

Comments

@rodvand
Copy link
Contributor

rodvand commented Mar 14, 2022

NetBox version

v3.2.0-beta2

Python version

3.8

Steps to Reproduce

  1. Find a device not racked
  2. Edit the device
  3. Do not select a rack, but go to rack position and start a search

Expected Behavior

Expect not to be "allowed" to search for a rack position without defining a rack.

Observed Behavior

See an error banner showing parts of an exception.

Screenshot 2022-03-14 at 15 16 54

It seems that the search for a rack position uses the URL https://beta-demo.netbox.dev/api/dcim/racks/{{ rack }}/elevation/?brief=true&exclude=109&q=12 which mess up the request.
@rodvand rodvand added the type: bug A confirmed report of unexpected behavior in the application label Mar 14, 2022
@jeremystretch
Copy link
Member

This is reproducible on v3.1.9

@jeremystretch jeremystretch added the status: needs owner This issue is tentatively accepted pending a volunteer committed to its implementation label Mar 14, 2022
minitriga added a commit to minitriga/netbox that referenced this issue Mar 14, 2022
@minitriga
Fixes: netbox-community#8866 - Does not perform API Select Search if …
3edff89 
…a django peramiter has not been replaced
@minitriga minitriga mentioned this issue Mar 14, 2022
Merged
jeremystretch added a commit that referenced this issue Mar 30, 2022
@jeremystretch
Change log & cleanup for #8163, #8866
91e8f57
@jeremystretch jeremystretch added status: accepted This issue has been accepted for implementation and removed status: needs owner This issue is tentatively accepted pending a volunteer committed to its implementation labels Mar 30, 2022
@jeremystretch jeremystretch mentioned this issue Apr 5, 2022
Merged
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
status: accepted This issue has been accepted for implementation type: bug A confirmed report of unexpected behavior in the application
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

APISelect JavaScript only perform fetch if Django substitutes have been replaced. minitriga/netbox
2 participants
@rodvand @jeremystretch