Fix Bug in report serialization #13945
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @Haeki, thank you for working on this, however it seems to have been resolved by @arthanson in PR #13958. While your approach is valid, the alternative solution of instantiating the report prior to serialization is more consistent with how reports are handled under the UI views, and avoids a potentially breaking change to the Report class. |
|
No problem. I'm Happy this got resolved so fast. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #13944
The name field should be
@classpropertyso that it can be serialized correctly.Im not sure if there are other fields that should be
@classpropertyinstead of@propertybut this change is enough to fix the Bug i encountered.