Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

12216 Add color to circuit-type and add to SVG rendering #14098

Merged
merged 5 commits into from
Oct 24, 2023
Merged

12216 Add color to circuit-type and add to SVG rendering #14098

merged 5 commits into from
Oct 24, 2023

Conversation

arthanson
Copy link
Collaborator

Fixes: #12216

  • Extending the circuit type model to include a color value (identical to how device roles are color-coded);
  • Updating the cable trace view to reflect the circuit type's color and name.
    Monosnap Cable Trace for Circuit Termination 1002840283: Termination Z | NetBox 2023-10-20 15-09-54

@arthanson arthanson changed the base branch from develop to feature October 20, 2023 22:13
@arthanson arthanson added this to the v3.7 milestone Oct 20, 2023
@arthanson arthanson marked this pull request as ready for review October 20, 2023 22:25
@arthanson arthanson changed the title DRAFT: 12216 Add color to circuit-type and add to SVG rendering 12216 Add color to circuit-type and add to SVG rendering Oct 20, 2023
jeremystretch
jeremystretch requested changes Oct 23, 2023
View reviewed changes
Copy link
Member

@jeremystretch jeremystretch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

netbox/circuits/forms/bulk_edit.py Outdated Show resolved Hide resolved
netbox/circuits/forms/bulk_edit.py Outdated Show resolved Hide resolved
netbox/dcim/svg/cables.py Outdated Show resolved Hide resolved
@jeremystretch jeremystretch merged commit ae447bd into feature Oct 24, 2023
8 checks passed
@jeremystretch jeremystretch deleted the 12216-circuit-color branch October 24, 2023 12:19
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jeremystretch jeremystretch jeremystretch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v3.7
Development

Successfully merging this pull request may close these issues.

Add colors to Circuit Types model and use this when rendering cable traces
2 participants
@arthanson @jeremystretch