Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

13230 Allow Devices to be excluded from Rack utilization #14099

Merged
merged 7 commits into from
Oct 24, 2023

Conversation

arthanson
Copy link
Collaborator

@arthanson arthanson commented Oct 20, 2023

Fixes: #13230

Sets flag to exclude items from rack utilization. Not sure if there is a better (shorter) name that would work exclude_from_utilization is descriptive, but a bit verbose.

@jeremystretch jeremystretch added this to the v3.7 milestone Oct 23, 2023
@arthanson arthanson marked this pull request as ready for review October 23, 2023 14:31
@jeremystretch jeremystretch changed the title DRAFT: 13230 Allow Devices to be excluded from Rack utilization 13230 Allow Devices to be excluded from Rack utilization Oct 24, 2023
Copy link
Member

@jeremystretch jeremystretch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is still missing a few things:

  • Add the exclude_from_utilization field to the REST API serializer
  • Add a filter for exclude_from_utilization on DeviceTypeFilterSet

The developer docs has a page on extending models that works well as a checklist for this sort of thing.

netbox/dcim/forms/bulk_edit.py Outdated Show resolved Hide resolved
netbox/dcim/models/racks.py Outdated Show resolved Hide resolved
arthanson and others added 2 commits October 24, 2023 07:48
Co-authored-by: Jeremy Stretch <jstretch@netboxlabs.com>
@jeremystretch jeremystretch merged commit 7274e75 into feature Oct 24, 2023
8 checks passed
@jeremystretch jeremystretch deleted the 13230-rack-utilization branch October 24, 2023 15:29
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants