Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closes #13334: Record error message on failed jobs #14106

Merged
merged 1 commit into from
Oct 31, 2023

Conversation

jeremystretch
Copy link
Member

Fixes: #13334

  • Add an optional error text field on Job
  • Extend the terminate() method to support passing an error message for failed jobs
  • Update calls to Job.terminate() to pass error message where applicable

@jeremystretch jeremystretch added this to the v3.7 milestone Oct 23, 2023
Copy link
Collaborator

@arthanson arthanson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Q: Would there be any security implications to this as showing the error would include traceback info. Would we want a permission to show this info on the job results at all? Probably not, but just wanted to mention it.

@jeremystretch
Copy link
Member Author

AFAICT the error just includes the error message tied to the exception itself; it shouldn't include a traceback with it.

@jeremystretch jeremystretch merged commit 7323668 into feature Oct 31, 2023
8 checks passed
@jeremystretch jeremystretch deleted the 13334-job-errors branch October 31, 2023 12:35
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants