Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closes #13427: Public model registration #14152

Merged
merged 3 commits into from
Nov 3, 2023
Merged

Closes #13427: Public model registration #14152

merged 3 commits into from
Nov 3, 2023

Conversation

jeremystretch
Copy link
Member

Closes: #13427

  • Record any models not having _netbox_private = True in registry['models']
  • Introduce a proxy model for ContentType with a custom ContentTypeManager
  • ContentTypeManager provides a public() method which returns all ContentTypes matching public models
  • Update imports of ContentType to use the proxy model where public() is needed

@jeremystretch jeremystretch mentioned this pull request Oct 31, 2023
Closed
@jeremystretch jeremystretch added this to the v3.7 milestone Oct 31, 2023
@jeremystretch jeremystretch marked this pull request as ready for review October 31, 2023 19:57
@jeremystretch jeremystretch merged commit 8dcbd66 into feature Nov 3, 2023
8 checks passed
@jeremystretch jeremystretch deleted the 13427-public-models branch November 3, 2023 14:33
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@arthanson arthanson arthanson requested changes

@abhi1693 abhi1693 Awaiting requested review from abhi1693

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v3.7
Development

Successfully merging this pull request may close these issues.
2 participants
@jeremystretch @arthanson