7537 add serial number to virtual machines #16407
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arthanson
changed the title
|
I could see Serials being set to unique for a specific cluster. but non-unique outside the cluster |
jeremystretch
requested changes
Jun 7, 2024
There was a problem hiding this comment.
Missing a few items:
- Add the serial field to the VM template
- Add the serial field to the search indexer
(Remember there's a checklist for adding new fields to models.)
jeremystretch
requested changes
Jun 11, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #7537
Added serial number field, kept it as non-unique? Wasn't sure if multiple vendors would have conflicting serial numbers if they aren't UUID, can change to unique if needed?
Didn't add to bulk edit as it didn't make sense to set multiple ones the same.