Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes: #17648 - Fix exception thrown in Job.delete() when no object_type specified #17657

Merged
merged 4 commits into from
Oct 7, 2024

Conversation

DanSheps
Copy link
Member

@DanSheps DanSheps commented Oct 2, 2024

Fixes: #17648 - Fix exception thrown in Job.delete() when no object_type specified

  • Change Job.delete() to use get_queue_for_model
  • Fix related issue in Job.get_absolute_url()

@DanSheps DanSheps self-assigned this Oct 2, 2024
@DanSheps DanSheps linked an issue Oct 2, 2024 that may be closed by this pull request
@DanSheps DanSheps removed a link to an issue Oct 2, 2024
@jeremystretch jeremystretch merged commit 2fd23f3 into develop Oct 7, 2024
6 checks passed
@jeremystretch jeremystretch deleted the 17648-fix-delete-of-task branch October 7, 2024 13:00
bctiemann pushed a commit that referenced this pull request Oct 11, 2024
…_type specified (#17657)

* Fixes: #17648 - Fix exception thrown in `Job.delete()` when no object_type specified

* Remove unrelated fix

* Change back elif to if

* Remove unused imports

---------

Co-authored-by: Jeremy Stretch <jstretch@netboxlabs.com>
jeremystretch added a commit to alehaa/netbox that referenced this pull request Oct 11, 2024
…` when no object_type specified (netbox-community#17657)

* Fixes: netbox-community#17648 - Fix exception thrown in `Job.delete()` when no object_type specified

* Remove unrelated fix

* Change back elif to if

* Remove unused imports

---------

Co-authored-by: Jeremy Stretch <jstretch@netboxlabs.com>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

When a background job is scheduled without an instance, delete() on the job model will throw exceptions
2 participants