Fixes: #17663 - Only remove extraneous attributes from extra if changing to a BooleanFilter #17670
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bctiemann
added a commit
that referenced
this pull request
Oct 11, 2024
…ing to a BooleanFilter (#17670) * Only remove extraneous attributes from extra if changing to a BooleanField * Add tests for MultipleChoiceField icontains and negation * Use enum in test consistently * Reorganize tests * Add __empty test to base filter lookup tests * Fix test name * Change var name for clarity
jeremystretch
pushed a commit
to alehaa/netbox
that referenced
this pull request
Oct 11, 2024
…m extra if changing to a BooleanFilter (netbox-community#17670) * Only remove extraneous attributes from extra if changing to a BooleanField * Add tests for MultipleChoiceField icontains and negation * Use enum in test consistently * Reorganize tests * Add __empty test to base filter lookup tests * Fix test name * Change var name for clarity
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #17663
Refines #17574 to ensure we only remove
choicesfrom the filter'sextraattributes if we are artificially changing it to aBooleanFilter(i.e. if the lookup is__empty). This fixes an issue wherechoiceswas not being respected in the case ofMultipleChoiceFieldwhere it should be allowed.Also adds a test to ensure
MultipleChoiceFieldcharacter-based lookups are exercised.Also adds tests for
__emptylookup to the base filter lookup tests to exercise that behavior generically.